Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Renable email link to submitted file #1236

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Sep 4, 2023

Issue #1225

Replaces #1228

tests/php/Model/SubmittedFileFieldTest.php Outdated Show resolved Hide resolved
tests/php/Model/SubmittedFileFieldTest.php Outdated Show resolved Hide resolved
code/Model/Submission/SubmittedFileField.php Outdated Show resolved Hide resolved
lang/en.yml Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5.15/you-must-log-in branch from a39aa3b to 9ef8f7e Compare September 5, 2023 04:45
@emteknetnz emteknetnz force-pushed the pulls/5.15/you-must-log-in branch 2 times, most recently from e536b2d to 423c01f Compare September 5, 2023 22:04
Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Works perfect.
Just small change.

tests/php/Model/SubmittedFileFieldTest.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5.15/you-must-log-in branch from 423c01f to f1510dc Compare September 5, 2023 22:54
Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Solution was tested locally.

@sabina-talipova sabina-talipova merged commit c8bf90c into silverstripe:5.15 Sep 5, 2023
@sabina-talipova sabina-talipova deleted the pulls/5.15/you-must-log-in branch September 5, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants